[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 01/11] block: add error parameter to bdrv_sna
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-devel] [PATCH v4 01/11] block: add error parameter to bdrv_snapshot_create() and related functions |
|
Date: |
Tue, 9 Apr 2013 15:43:49 +0200 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 09.04.2013 um 15:13 hat Markus Armbruster geschrieben:
> When doing an error conversion, you have to decide "where to cut".
> Everything above the cut is converted to Error. Everything below keeps
> using other methods, such as returning -errno.
>
> Using Error sucks, because it's cumbersome.
>
> Using Error is nice, because you can report errors in more detail.
>
> Converting to Error is worthwhile when the niceness is worth the
> suckage.
>
> This patch cuts below the block driver API. I'm not saying that's bad.
> I just want to hear Kevin's opinion on it (cc'ed).
I think for bdrv_snapshot_create() it could make sense to pass an Error
object to the block drivers. Same thing for bdrv_create() or
bdrv_open(). Most other functions probably can't make much use of it.
Kevin