[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] migration: initialize RAM to zero
|
From: |
Juan Quintela |
|
Subject: |
Re: [Qemu-devel] [PATCH v2] migration: initialize RAM to zero |
|
Date: |
Tue, 09 Apr 2013 17:22:31 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) |
Paolo Bonzini <address@hidden> wrote:
> Il 09/04/2013 15:20, Markus Armbruster ha scritto:
>>> > -#if defined(CONFIG_VALGRIND)
>>> > - if (running_on_valgrind < 0) {
>>> > - /* First call, test whether we are running on Valgrind.
>>> > - This is a substitute for RUNNING_ON_VALGRIND from valgrind.h.
>>> > */
>>> > - const char *ld = getenv("LD_PRELOAD");
>>> > - running_on_valgrind = (ld != NULL && strstr(ld, "vgpreload"));
>>> > + if ((intptr_t) ptr == -1) {
>> Recommend ptr == MAP_FAILED
>>
>
> Worth respinning?
Do it, and put the:
Reviewed-by: Juan Quintela <address@hidden>