Re: [Qemu-devel] [PATCH] virtio-9p: Fix virtio-9p no longer building after hw-dirs branch merge

[KONRAD Frédéric]

On 09/04/2013 21:13, Anthony Liguori wrote:
> Paolo Bonzini <address@hidden> writes:
>
> > Il 09/04/2013 10:22, Hans de Goede ha scritto:
> > > Signed-off-by: Hans de Goede <address@hidden>
> > > Cc: Paolo Bonzini <address@hidden>
> > > ---
> > >   hw/9pfs/virtio-9p-device.c | 2 +-
> > >   1 file changed, 1 insertion(+), 1 deletion
> > Ouch, /me installs libcap-ng-devel.
> On a fresh F18, I tried to find all the deps needed that can be
> reasonably installed.  This is what I came up with:
>
> # yum install xen-devel iasl libfdt-devel libcap-ng-devel \
>    spice-server-devel gnutls-devel cyrus-sasl-devel libjpeg-turbo-devel \
>    libpng-devel uuid-devel xfsprogs-devel ncurses-devel brlapi-devel \
>    libcurl-devel bluez-libs-devel libiscsi-devel libcap-ng-devel \
>    spice-protocol SDL-devel libcap-devel usbredir-devel libseccomp-devel \
>    ceph-devel
>
> Still missing GlusterFS, VDE, and iscsi.  F18 doesn't seem to
> package these at appropriate versions.
>
> Regards,
>
> Anthony Liguori
Isn't libattr-devel needed as well for virtio-9p?

I needed it to test my patch-set this morning.
> > Thanks.
> >
> > Paolo
> >
> > > diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c
> > > index 43f930e..b476b81 100644
> > > --- a/hw/9pfs/virtio-9p-device.c
> > > +++ b/hw/9pfs/virtio-9p-device.c
> > > @@ -12,11 +12,11 @@
> > >    */
> > >   
> > >   #include "hw/virtio/virtio.h"
> > > +#include "hw/virtio/virtio-9p.h"
> > >   #include "hw/i386/pc.h"
> > >   #include "qemu/sockets.h"
> > >   #include "virtio-9p.h"
> > >   #include "fsdev/qemu-fsdev.h"
> > > -#include "virtio-9p-device.h"
> > >   #include "virtio-9p-xattr.h"
> > >   #include "virtio-9p-coth.h"
> > >