[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/5] hostmem: init/finalize hostmem listener
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 5/5] hostmem: init/finalize hostmem listener |
Date: |
Thu, 11 Apr 2013 15:14:19 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 |
Il 11/04/2013 14:08, liu ping fan ha scritto:
>>> >> /* clean up network at qemu process termination */
>>> >> atexit(&net_cleanup);
>>> >> + atexit(&hostmem_finalize);
>> >
>> > This should be in hostmem_init.
>> >
> Ok, thanks. And extra, for the hostmem_init, what about something like
> #define block_init(function) module_init(function, MODULE_INIT_BLOCK)
Actually, I would prefer that you do not use a global, so the above
comment doesn't really apply unless someone overrides me and tell you to
use a global.
Paolo
- [Qemu-devel] [PATCH 4/5] virtio-blk: release reference to RAM's memoryRegion, (continued)
[Qemu-devel] [PATCH 5/5] hostmem: init/finalize hostmem listener, Liu Ping Fan, 2013/04/01