[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/4] Fix JSON string formatter
From: |
Laszlo Ersek |
Subject: |
Re: [Qemu-devel] [PATCH 0/4] Fix JSON string formatter |
Date: |
Thu, 11 Apr 2013 19:03:44 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 |
On 04/11/13 18:07, Markus Armbruster wrote:
> This should unbreak "make check" on machines where char is unsigned.
> Blue, please give it a whirl.
>
> The JSON parser is still as broken as ever. Left for another day.
>
> v2:
> - Rebased, trivial conflicts in PATCH 1/4.
> - Make mod_utf8_codepoint() treat empty input as invalid sequence of
> length zero (both when n==0 and when n>0 && *s==0). No code in this
> series passes empty input.
> - Some commit messages and comments improved.
>
> Markus Armbruster (4):
> unicode: New mod_utf8_codepoint()
> check-qjson: Improve a few comments, delete bogus ones
> check-qjson: Test noncharacters other than U+FFFE, U+FFFF in strings
> qjson: to_json() case QTYPE_QSTRING is buggy, rewrite
>
> include/qemu-common.h | 3 +
> qobject/qjson.c | 102 ++++++++---------
> tests/check-qjson.c | 308
> ++++++++++++++++++++++++++++++--------------------
> util/Makefile.objs | 2 +-
> util/unicode.c | 100 ++++++++++++++++
> 5 files changed, 333 insertions(+), 182 deletions(-)
> create mode 100644 util/unicode.c
>
I compared this v2 series patch-wise to v1.
Reviewed-by: Laszlo Ersek <address@hidden>
- [Qemu-devel] [PATCH 0/4] Fix JSON string formatter, Markus Armbruster, 2013/04/11
- [Qemu-devel] [PATCH 1/4] unicode: New mod_utf8_codepoint(), Markus Armbruster, 2013/04/11
- [Qemu-devel] [PATCH 2/4] check-qjson: Improve a few comments, delete bogus ones, Markus Armbruster, 2013/04/11
- [Qemu-devel] [PATCH 3/4] check-qjson: Test noncharacters other than U+FFFE, U+FFFF in strings, Markus Armbruster, 2013/04/11
- [Qemu-devel] [PATCH 4/4] qjson: to_json() case QTYPE_QSTRING is buggy, rewrite, Markus Armbruster, 2013/04/11
- Re: [Qemu-devel] [PATCH 0/4] Fix JSON string formatter,
Laszlo Ersek <=
- Re: [Qemu-devel] [PATCH 0/4] Fix JSON string formatter, Markus Armbruster, 2013/04/11
- Re: [Qemu-devel] [PATCH 0/4] Fix JSON string formatter, Blue Swirl, 2013/04/13