[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-trivial] [PATCH] target-moxie: Fix VMState regist
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [Qemu-trivial] [PATCH] target-moxie: Fix VMState registration |
Date: |
Fri, 12 Apr 2013 13:32:52 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Mon, Apr 08, 2013 at 04:51:46PM +0100, Peter Maydell wrote:
> Register the CPU VMState in the correct way, via cpu_class_set_vmsd(),
> rather than doing it in two different wrong ways (once by providing
> cpu_save and cpu_load functions, and once by setting the vmsd field in
> DeviceClass).
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> Having just revamped the target-arm vmstate code I now have a
> better grasp of how it should work, so I noticed we didn't quite
> get moxie right. Not really very tested since I couldn't find a test
> image to try, but should work better than the previous code...
>
> target-moxie/cpu.c | 2 +-
> target-moxie/cpu.h | 2 --
> target-moxie/machine.c | 12 +-----------
> 3 files changed, 2 insertions(+), 14 deletions(-)
Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches
Stefan