Re: [Qemu-devel] [PATCH] pixman: remove -Wredundand-decls

[Markus Armbruster]

Alexey Kardashevskiy <address@hidden> writes:

> On 04/15/2013 05:08 PM, Markus Armbruster wrote:
>> Alexey Kardashevskiy <address@hidden> writes:
>>
>>> The assert.h header file from Fedora18 does not have #ifdef-#endif
>>> brackets around __assertXXXX function so it cannot compile with
>>> the -Wredundant-decls switch on.
>>>
>>> Some Linux distributions (such as Debian Wheezy) still do have those
>>> brackets arounb __assertXXXX functions (#ifndef _ASSERT_H_DECLS) but
>>> the version of assert.h on http://sourceware.org/git/?p=glibc.git does not
>>> so we should not be using -Wredundant-decls.
>>>
>>> The patch removes it.
>>>
>>> Signed-off-by: Alexey Kardashevskiy <address@hidden>
>>> ---
>>>   include/ui/qemu-pixman.h |    6 ------
>>>   1 file changed, 6 deletions(-)
>>>
>>> diff --git a/include/ui/qemu-pixman.h b/include/ui/qemu-pixman.h
>>> index b032f52..6f473f9 100644
>>> --- a/include/ui/qemu-pixman.h
>>> +++ b/include/ui/qemu-pixman.h
>>> @@ -7,13 +7,7 @@
>>>   #define QEMU_PIXMAN_H
>>>
>>>   /* pixman-0.16.0 headers have a redundant declaration */
>>> -#ifdef CONFIG_PRAGMA_DIAGNOSTIC_AVAILABLE
>>> -#pragma GCC diagnostic ignored "-Wredundant-decls"
>>> -#endif
>>>   #include <pixman.h>
>>> -#ifdef CONFIG_PRAGMA_DIAGNOSTIC_AVAILABLE
>>> -#pragma GCC diagnostic error "-Wredundant-decls"
>>> -#endif
>>>
>>>   #include "qemu/typedefs.h"
>>
>> Patch description doesn't seem to fit the patch.  The patch doesn't
>> remove -Wredundant-decls, it removes its suppression in one specific
>> place.  Please advise.
>
> The patch removes both suppression AND enabling, the second chunk
> enabled this check back after #include, no matter if it was enabled or
> not.

Trouble is there is no second chunk.

If you're proposing to remove -Wredundant-decls globally, you'll have to
explain what problems exactly it causes.

>> Oh, and use a spell-checker :)
>
> The one build into thunderbird does not show any spelling errors
> (except file names, of course) :)

arounb
-Wredundand-decls