Re: [Qemu-devel] [PATCH] pixman: remove -Wredundand-decls

[Peter Maydell]

On 15 April 2013 10:50, Alexey Kardashevskiy <address@hidden> wrote:
> /home/alexey/pcipassthru/qemu-impreza/../lib4qemu/usr/include/assert.h:67:13:
> error: redundant redeclaration of '__assert_fail' [-Werror=redundant-decls]
> /home/alexey/pcipassthru/qemu-impreza/../lib4qemu/usr/include/assert.h:67:13:
> note: previous declaration of '__assert_fail' was here
> /home/alexey/pcipassthru/qemu-impreza/../lib4qemu/usr/include/assert.h:72:13:
> error: redundant redeclaration of '__assert_perror_fail'
> [-Werror=redundant-decls]

This copy of assert.h seems to be broken. The declarations
should be guarded (by _ASSERT_H_DECLS in my system's copy).
If it's widespread we might have to work around this.

> If we disable that warning, I do not what we loose. The "bug" above is not a
> bug at all.

What we lose is that we are no longer informed when people
inadvertently introduce redundant declarations into QEMU itself.

-- PMM