Re: [Qemu-devel] [PATCH] pixman: remove -Wredundand-decls

[Alexey Kardashevskiy]

On 04/15/2013 08:01 PM, Peter Maydell wrote:
> On 15 April 2013 10:50, Alexey Kardashevskiy <address@hidden> wrote:
> > /home/alexey/pcipassthru/qemu-impreza/../lib4qemu/usr/include/assert.h:67:13:
> > error: redundant redeclaration of '__assert_fail' [-Werror=redundant-decls]
> > /home/alexey/pcipassthru/qemu-impreza/../lib4qemu/usr/include/assert.h:67:13:
> > note: previous declaration of '__assert_fail' was here
> > /home/alexey/pcipassthru/qemu-impreza/../lib4qemu/usr/include/assert.h:72:13:
> > error: redundant redeclaration of '__assert_perror_fail'
> > [-Werror=redundant-decls]
>
> This copy of assert.h seems to be broken. The declarations
> should be guarded (by _ASSERT_H_DECLS in my system's copy).

Debian? It uses eglibc which is fork (or clone?) of glibc.

> If it's widespread we might have to work around this.

It is in fedora 18 and glibc's git master branch. Why "if"?

And this is not it. I just managed to suppress others with 
-Wredundand-decls, like the one with strtold() defined twice in 
/usr/include/stdlib.h and /usr/include/bits/stdlib-ldbl.h and some others.


I suspect I am getting these errors because I am the only person who is 
trying to cross compile or/and when host and target endianness differ.

Does anyone do cross compilation (with different endianness?) on a regular 
basis? My colleagues do not :)


> > If we disable that warning, I do not what we loose. The "bug" above is not a
> > bug at all.
>
> What we lose is that we are no longer informed when people
> inadvertently introduce redundant declarations into QEMU itself.



--
Alexey