[Qemu-devel] Curious about relaxation of bdrv_is_sg() for scsi-generic

[Markus Armbruster]

Commit 9839245 "ISCSI: Add SCSI passthrough via scsi-generic to
libiscsi" contains this hunk:

diff --git a/hw/scsi-generic.c b/hw/scsi-generic.c
index d856d23..8d51060 100644
--- a/hw/scsi-generic.c
+++ b/hw/scsi-generic.c
@@ -400,12 +400,6 @@ static int scsi_generic_initfn(SCSIDevice *s)
         return -1;
     }
 
-    /* check we are really using a /dev/sg* file */
-    if (!bdrv_is_sg(s->conf.bs)) {
-        error_report("not /dev/sg*");
-        return -1;
-    }
-
     if (bdrv_get_on_error(s->conf.bs, 0) != BLOCK_ERR_STOP_ENOSPC) {
         error_report("Device doesn't support drive option werror");
         return -1;

Why could we relax the "must be sg" requirement here?  I know it's been
a while...