[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH uq/master v3 1/2] kvm: reset state from the CPU'
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH uq/master v3 1/2] kvm: reset state from the CPU's reset method |
|
Date: |
Mon, 15 Apr 2013 14:55:13 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 |
Il 15/04/2013 14:20, Andreas Färber ha scritto:
> Fine with me.
>
> Have you tested whether i386 needs a similar stub on non-x86? If so then
>
> Reviewed-by: Andreas Färber <address@hidden>
It doesn't need it, because the prototype is declared always in kvm_i386.h.
I didn't test non-x86, but I tested an alternative patches that places
s390's kvm_arch_reset_vcpu prototype outside "#ifdef CONFIG_KVM". That
also compiled fine on non-s390, and it's what will happen when compiling
on non-x86.
I figured that the dummy inline definition was closer in style to the
existing s390 code, so that's what I chose for submission.
Paolo