Re: [Qemu-devel] [PATCH v3 8/8] virtio-rng: cleanup: use QOM casts.

[Andreas Färber]

Am 14.04.2013 15:01, schrieb address@hidden:
> From: KONRAD Frederic <address@hidden>
> 
> As the virtio-rng-pci and virtio-rng-s390 are switched to the new API,

and virtio-rng-ccw ;)

> we can use QOM casts.
> 
> Signed-off-by: KONRAD Frederic <address@hidden>
> ---
>  hw/virtio/virtio-rng.c         | 31 +++++++++++++++++--------------
>  include/hw/virtio/virtio-rng.h |  2 +-
>  2 files changed, 18 insertions(+), 15 deletions(-)

Thanks,

Reviewed-by: Andreas Färber <address@hidden>

I was surprised to see FOO(opaque) since we usually try to avoid it for
performance reasons, but it's not forbidden either.
Also, leaving the variable name as "s" would've spared a few lines but
so what. :)

Regards,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg