qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 8/8] virtio-rng: cleanup: use QOM casts.


From: KONRAD Frédéric
Subject: Re: [Qemu-devel] [PATCH v3 8/8] virtio-rng: cleanup: use QOM casts.
Date: Mon, 15 Apr 2013 16:33:43 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4

On 15/04/2013 15:34, Andreas Färber wrote:
Am 14.04.2013 15:01, schrieb address@hidden:
From: KONRAD Frederic <address@hidden>

As the virtio-rng-pci and virtio-rng-s390 are switched to the new API,
and virtio-rng-ccw ;)

we can use QOM casts.

Signed-off-by: KONRAD Frederic <address@hidden>
---
  hw/virtio/virtio-rng.c         | 31 +++++++++++++++++--------------
  include/hw/virtio/virtio-rng.h |  2 +-
  2 files changed, 18 insertions(+), 15 deletions(-)
Thanks,

Reviewed-by: Andreas Färber <address@hidden>

I was surprised to see FOO(opaque) since we usually try to avoid it for
performance reasons, but it's not forbidden either.
True, I had taken that in account but forget this series :/.

Is it better to change that?

Thanks,
Fred
Also, leaving the variable name as "s" would've spared a few lines but
so what. :)

Regards,
Andreas





reply via email to

[Prev in Thread] Current Thread [Next in Thread]