[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 17/19] qdev: set device's parent before calling
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH 17/19] qdev: set device's parent before calling realize() down inheritance chain. |
Date: |
Mon, 15 Apr 2013 17:48:49 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 |
Am 11.04.2013 16:51, schrieb Igor Mammedov:
> Currently device_set_realized() sets parent only after device was realized,
> But qdev_device_add() sets it before device is realized.
> Make behavior consistent and alter device_set_realized() to behave like
> qdev_device_add().
>
> It will allow to set link<> properties in realize() method in classes
> inherited from DEVICE.
>
> Signed-off-by: Igor Mammedov <address@hidden>
> Reviewed-by: Paolo Bonzini <address@hidden>
> ---
> * Usage examples
> - conversion to CPU back-link property in APIC
> - pre-allocate link<CPU[n]> at board level, and populate them
> at realize time when CPUs are created.
> ---
> hw/core/qdev.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
Thanks, applied to qom-cpu:
https://github.com/afaerber/qemu-cpu/commits/qom-cpu
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- Re: [Qemu-devel] [PATCH 11/19] target-i386: introduce apic-id property, (continued)
- Re: [Qemu-devel] [PATCH 11/19] target-i386: introduce apic-id property, Eduardo Habkost, 2013/04/12
- Re: [Qemu-devel] [PATCH 11/19] target-i386: introduce apic-id property, Igor Mammedov, 2013/04/12
- Re: [Qemu-devel] [PATCH 11/19] target-i386: introduce apic-id property, Eduardo Habkost, 2013/04/12
- Re: [Qemu-devel] [PATCH 11/19] target-i386: introduce apic-id property, li guang, 2013/04/14
- Re: [Qemu-devel] [PATCH 11/19] target-i386: introduce apic-id property, Igor Mammedov, 2013/04/15
- Re: [Qemu-devel] [PATCH 11/19] target-i386: introduce apic-id property, Eduardo Habkost, 2013/04/15
- Re: [Qemu-devel] [PATCH 11/19] target-i386: introduce apic-id property, Igor Mammedov, 2013/04/15
- Re: [Qemu-devel] [PATCH 11/19] target-i386: introduce apic-id property, Eduardo Habkost, 2013/04/15
- Re: [Qemu-devel] [PATCH 11/19] target-i386: introduce apic-id property, Igor Mammedov, 2013/04/15
[Qemu-devel] [PATCH 17/19] qdev: set device's parent before calling realize() down inheritance chain., Igor Mammedov, 2013/04/11
- Re: [Qemu-devel] [PATCH 17/19] qdev: set device's parent before calling realize() down inheritance chain.,
Andreas Färber <=
[Qemu-devel] [PATCH 14/19] target-i386: replace MSI_SPACE_SIZE with APIC_SPACE_SIZE, Igor Mammedov, 2013/04/11
[Qemu-devel] [PATCH 04/19] cpu: call cpu_synchronize_post_init() from CPUClass.realize() if hotplugged, Igor Mammedov, 2013/04/11
Re: [Qemu-devel] [PATCH 04/19] cpu: call cpu_synchronize_post_init() from CPUClass.realize() if hotplugged, Eduardo Habkost, 2013/04/15
[Qemu-devel] [PATCH 15/19] target-i386: move APIC to ICC bus, Igor Mammedov, 2013/04/11