[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 05/15] raw-win32: Use bdrv_open options instead
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 05/15] raw-win32: Use bdrv_open options instead of filename |
Date: |
Mon, 15 Apr 2013 13:16:40 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130402 Thunderbird/17.0.5 |
On 04/12/2013 02:47 PM, Kevin Wolf wrote:
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block/raw-win32.c | 57
> +++++++++++++++++++++++++++++++++++++++++++++----------
> 1 file changed, 47 insertions(+), 10 deletions(-)
>
> +static int raw_open(BlockDriverState *bs, const char *unused,
> QDict *options, int flags)
> {
> BDRVRawState *s = bs->opaque;
> int access_flags;
> DWORD overlapped;
> + QemuOpts *opts;
> + Error *local_err = NULL;
> + const char* filename;
Copy-and-paste formatting of this line from 4/15. Same caveat about it
being trivial enough to add this once fixed:
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 01/15] block: Fail gracefully when using a format driver on protocol level, (continued)
[Qemu-devel] [PATCH 02/15] block: Add driver-specific options for backing files, Kevin Wolf, 2013/04/12
[Qemu-devel] [PATCH 03/15] block: Enable filename option, Kevin Wolf, 2013/04/12
[Qemu-devel] [PATCH 04/15] raw-posix: Use bdrv_open options instead of filename, Kevin Wolf, 2013/04/12
[Qemu-devel] [PATCH 05/15] raw-win32: Use bdrv_open options instead of filename, Kevin Wolf, 2013/04/12
- Re: [Qemu-devel] [PATCH 05/15] raw-win32: Use bdrv_open options instead of filename,
Eric Blake <=
[Qemu-devel] [PATCH 06/15] blkdebug: Use bdrv_open options instead of filename, Kevin Wolf, 2013/04/12
[Qemu-devel] [PATCH 07/15] blkverify: Use bdrv_open options instead of filename, Kevin Wolf, 2013/04/12
[Qemu-devel] [PATCH 08/15] curl: Use bdrv_open options instead of filename, Kevin Wolf, 2013/04/12
[Qemu-devel] [PATCH 09/15] gluster: Use bdrv_open options instead of filename, Kevin Wolf, 2013/04/12
[Qemu-devel] [PATCH 10/15] iscsi: Use bdrv_open options instead of filename, Kevin Wolf, 2013/04/12