[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/3] debugcon: make debug message more readab
|
From: |
Jesse Larrew |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 2/3] debugcon: make debug message more readable |
|
Date: |
Mon, 15 Apr 2013 21:44:04 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 |
On 04/14/2013 09:14 PM, liguang wrote:
> #ifdef DEBUG_DEBUGCON
> - printf("debugcon: write addr=0x%04" HWADDR_PRIx " val=0x%02x\n", addr,
> val);
> + printf(" [debugcon: write addr=0x%04" HWADDR_PRIx " val=0x%02]\n", addr,
> val);
I like the reformatting, but it looks like you accidentally clobbered the
'x' when you added the ']'. This is the cause of the compiler warnings in
patch #3.
Jesse Larrew
Software Engineer, KVM Team
IBM Linux Technology Center
Phone: (512) 973-2052 (T/L: 363-2052)
address@hidden