Re: [Qemu-devel] [PULL 0/8] rdma: migration support

[Anthony Liguori]

Paolo Bonzini <address@hidden> writes:

> Il 16/04/2013 04:44, address@hidden ha scritto:
>> From: "Michael R. Hines" <address@hidden>
>> 
>> The following changes since commit 24a6e7f4d91e9ed5f8117ecb083431a23f8609a0:
>> 
>>   virtio-balloon: fix dynamic properties. (2013-04-15 17:06:58 -0500)
>> 
>> are available in the git repository at:
>> 
>>   address@hidden:hinesmr/qemu.git rdma_patch_v2
>> 
>> for you to fetch changes up to 633d528cd87dc16f9095572e1b301a243728db56:
>> 
>>   rdma: add documentation (2013-04-15 22:27:34 -0400)
>> 
>> ----------------------------------------------------------------
>> Michael R. Hines (8):
>>       rdma: introduce qemu_ram_foreach_block
>>       rdma: new QEMUFileOps hooks
>>       rdma: export ram_handle_compressed()
>>       rdma: introduce capability for chunk registration
>>       rdma: core rdma logic
>>       rdma: send pc.ram
>>       rdma: print out throughput while debugging
>>       rdma: add documentation
>> 
>>  Makefile.objs                 |    1 +
>>  arch_init.c                   |   59 +-
>>  configure                     |   29 +
>>  docs/rdma.txt                 |  336 +++++
>>  exec.c                        |    9 +
>>  include/exec/cpu-common.h     |    5 +
>>  include/migration/migration.h |   23 +
>>  include/migration/qemu-file.h |   30 +
>>  migration-rdma.c              | 2732 
>> +++++++++++++++++++++++++++++++++++++++++
>>  migration.c                   |   27 +-
>>  qapi-schema.json              |    2 +-
>>  savevm.c                      |   75 +-
>>  12 files changed, 3307 insertions(+), 21 deletions(-)
>>  create mode 100644 docs/rdma.txt
>>  create mode 100644 migration-rdma.c
>> 
>
> NACK,

I am not planning on pulling/applying these patches directly.  I'd
expect them to be applied to Juan's tree and collecting Reviewed-bys on
the list.

Regards,

Anthony Liguori

>
> at least there is a missing "x-" in the prefix of the chunk registration
> capability.
>
> Reviewing more now.
>
> Paolo