Re: [Qemu-devel] [qom-cpu PATCH 4/7] target-i386/cpu.c: Break lines on kvm_cpu_fill_host()

[Igor Mammedov]

On Mon, 15 Apr 2013 16:25:37 -0300
Eduardo Habkost <address@hidden> wrote:

> Break lines so they don't get too long once the *_features fields are
> replaced by an array.
> 
> Signed-off-by: Eduardo Habkost <address@hidden>
> ---
>  target-i386/cpu.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index 732cafd..5390ca5 100644
> --- a/target-i386/cpu.c
> +++ b/target-i386/cpu.c
> @@ -918,8 +918,10 @@ static void kvm_cpu_fill_host(x86_def_t *x86_cpu_def)
>      x86_cpu_def->stepping = eax & 0x0F;
>  
>      x86_cpu_def->level = kvm_arch_get_supported_cpuid(s, 0x0, 0, R_EAX);
> -    x86_cpu_def->features = kvm_arch_get_supported_cpuid(s, 0x1, 0, R_EDX);
> -    x86_cpu_def->ext_features = kvm_arch_get_supported_cpuid(s, 0x1, 0,
> R_ECX);
> +    x86_cpu_def->features =
> +        kvm_arch_get_supported_cpuid(s, 0x1, 0, R_EDX);
> +    x86_cpu_def->ext_features =
> +        kvm_arch_get_supported_cpuid(s, 0x1, 0, R_ECX);
>  
>      if (x86_cpu_def->level >= 7) {
>          x86_cpu_def->cpuid_7_0_ebx_features =

Reviewed 4-6/7 patches, they look good, I'd though would merge them since
they are doing the same repetitive thing and easy to review.