[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V12 14/18] block: dump to monitor for bdrv_snaps
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH V12 14/18] block: dump to monitor for bdrv_snapshot_dump() and bdrv_image_info_dump() |
Date: |
Tue, 16 Apr 2013 17:42:25 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130402 Thunderbird/17.0.5 |
On 04/13/2013 02:56 AM, Wenchao Xia wrote:
> This patch introduce a new print function, which will output message to
> monitor when it present. With it, bdrv_snapshot_dump() need no more buffer
> and can avoid string truncation, bdrv_image_info_dump() can also be used by
> hmp code later, besides qemu-img code.
Not a full review (yet), but can we get this particular cleanup rebased
to be done first in isolation, since Pavel's patches would benefit from
being based on top of this cleanup as well?
https://lists.gnu.org/archive/html/qemu-devel/2013-04/msg03287.html
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH V12 10/18] qmp: add interface query-snapshots, (continued)
- [Qemu-devel] [PATCH V12 10/18] qmp: add interface query-snapshots, Wenchao Xia, 2013/04/13
- [Qemu-devel] [PATCH V12 11/18] qmp: add recursive member in ImageInfo, Wenchao Xia, 2013/04/13
- [Qemu-devel] [PATCH V12 06/18] block: add check for VM snapshot in bdrv_query_snapshot_info_list(), Wenchao Xia, 2013/04/13
- [Qemu-devel] [PATCH V12 13/18] block: move bdrv_snapshot_dump() and dump_human_image_info() to block/qapi.c, Wenchao Xia, 2013/04/13
- [Qemu-devel] [PATCH V12 15/18] hmp: add function hmp_info_snapshots(), Wenchao Xia, 2013/04/13
- [Qemu-devel] [PATCH V12 17/18] hmp: show ImageInfo in 'info block', Wenchao Xia, 2013/04/13
- [Qemu-devel] [PATCH V12 14/18] block: dump to monitor for bdrv_snapshot_dump() and bdrv_image_info_dump(), Wenchao Xia, 2013/04/13
- Re: [Qemu-devel] [PATCH V12 14/18] block: dump to monitor for bdrv_snapshot_dump() and bdrv_image_info_dump(),
Eric Blake <=
- [Qemu-devel] [PATCH V12 12/18] qmp: add ImageInfo in BlockDeviceInfo used by query-block, Wenchao Xia, 2013/04/13
- [Qemu-devel] [PATCH V12 16/18] hmp: switch snapshot info function to qmp based one, Wenchao Xia, 2013/04/13
- [Qemu-devel] [PATCH V12 18/18] hmp: add parameters device and -v for info block, Wenchao Xia, 2013/04/13
- Re: [Qemu-devel] [PATCH V12 00/18] qmp/hmp interfaces for internal snapshot info, Wenchao Xia, 2013/04/21