[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qemu-iotests: Test subformats for vmdk
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH] qemu-iotests: Test subformats for vmdk |
Date: |
Wed, 17 Apr 2013 15:06:35 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 17.04.2013 um 14:58 hat Fam Zheng geschrieben:
> Added format options for testing vmdk subformats:
>
> $ ./check -h
> Usage: ./check [options] [testlist]
>
> common options
> -v verbose
>
> check options
> ...
> -vpc test vpc
> -vmdk test vmdk (identical to -vmdk-monolithicSparse)
> -vmdk-monolithicSparse
> test vmdk monolithic sparse
> -vmdk-monolithicFlat
> test vmdk monolithic flat
> -vmdk-twoGbMaxExtentSparse
> test vmdk two gb splitted sparse
> -vmdk-twoGbMaxExtentFlat
> test vmdk two gb splitted sparse
> -rbd test rbd
> ...
>
> Signed-off-by: Fam Zheng <address@hidden>
Shouldn't -o be enough to cover all of this? For example, we're also
running qcow2 tests with -o compat=[0.10|1.1] and don't introduce a
separate option for each.
In practice, of course, the problem is that the non-default is rarely
run. Maybe we should add a tests/qemu-iotest-slow.sh that covers some
more combinations.
> @@ -124,6 +127,7 @@ _make_test_img()
> -e "s# compat='[^']*'##g" \
> -e "s# compat6=\\(on\\|off\\)##g" \
> -e "s# static=\\(on\\|off\\)##g" \
> + -e "s# subformat='[^']*'##g" \
> -e "s# lazy_refcounts=\\(on\\|off\\)##g"
>
> # Start an NBD server on the image file, which is what we'll be talking
> to
This hunk we'll need in any case, of course.
Kevin