[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 15/17] thread-pool: drop thread_pool_active()
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v2 15/17] thread-pool: drop thread_pool_active() |
Date: |
Wed, 17 Apr 2013 15:13:32 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 |
Il 17/04/2013 15:07, Stefan Hajnoczi ha scritto:
> .io_flush() is no longer called so drop thread_pool_active(). The block
> layer is the only thread-pool.c user and it already tracks in-flight
> requests, therefore we do not need thread_pool_active().
>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
> thread-pool.c | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/thread-pool.c b/thread-pool.c
> index 0ebd4c2..096f007 100644
> --- a/thread-pool.c
> +++ b/thread-pool.c
> @@ -197,12 +197,6 @@ restart:
> }
> }
>
> -static int thread_pool_active(EventNotifier *notifier)
> -{
> - ThreadPool *pool = container_of(notifier, ThreadPool, notifier);
> - return !QLIST_EMPTY(&pool->head);
> -}
> -
> static void thread_pool_cancel(BlockDriverAIOCB *acb)
> {
> ThreadPoolElement *elem = (ThreadPoolElement *)acb;
> @@ -310,7 +304,7 @@ static void thread_pool_init_one(ThreadPool *pool,
> AioContext *ctx)
> QTAILQ_INIT(&pool->request_list);
>
> aio_set_event_notifier(ctx, &pool->notifier, event_notifier_ready,
> - thread_pool_active);
> + NULL);
> }
>
> ThreadPool *thread_pool_new(AioContext *ctx)
>
Reviewed-by: Polo Bonzini <address@hidden>
- [Qemu-devel] [PATCH v2 08/17] block/iscsi: drop iscsi_process_flush(), (continued)
- [Qemu-devel] [PATCH v2 08/17] block/iscsi: drop iscsi_process_flush(), Stefan Hajnoczi, 2013/04/17
- [Qemu-devel] [PATCH v2 12/17] block/sheepdog: drop have_co_req() and aio_flush_request(), Stefan Hajnoczi, 2013/04/17
- [Qemu-devel] [PATCH v2 16/17] tests: drop event_active_cb(), Stefan Hajnoczi, 2013/04/17
- [Qemu-devel] [PATCH v2 11/17] block/rbd: drop qemu_rbd_aio_flush_cb(), Stefan Hajnoczi, 2013/04/17
- [Qemu-devel] [PATCH v2 07/17] block/gluster: drop qemu_gluster_aio_flush_cb(), Stefan Hajnoczi, 2013/04/17
- [Qemu-devel] [PATCH v2 17/17] aio: drop io_flush argument, Stefan Hajnoczi, 2013/04/17
- [Qemu-devel] [PATCH v2 15/17] thread-pool: drop thread_pool_active(), Stefan Hajnoczi, 2013/04/17
- Re: [Qemu-devel] [PATCH v2 15/17] thread-pool: drop thread_pool_active(),
Paolo Bonzini <=
- [Qemu-devel] [PATCH v2 14/17] dataplane/virtio-blk: drop flush_true() and flush_io(), Stefan Hajnoczi, 2013/04/17
- Re: [Qemu-devel] [PATCH v2 00/17] aio: drop io_flush(), Paolo Bonzini, 2013/04/17