qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PULL v3 3/7] rdma: introduce capability for chunk regi


From: Michael R. Hines
Subject: Re: [Qemu-devel] [PULL v3 3/7] rdma: introduce capability for chunk registration
Date: Wed, 17 Apr 2013 12:00:56 -0400
User-agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130106 Thunderbird/17.0.2

On 04/17/2013 11:44 AM, Eric Blake wrote:
On 04/16/2013 10:20 PM, address@hidden wrote:
From: "Michael R. Hines" <address@hidden>

This capability allows you to disable dynamic chunk registration
for better throughput on high-performance links.

It is enabled by default.

Signed-off-by: Michael R. Hines <address@hidden>
---
+++ b/qapi-schema.json
@@ -602,7 +602,7 @@
  # Since: 1.2
Normally, I'd ask that you document the option above; something like:

# @x-chunk-register-destination: do something (since 1.5)

  ##
  { 'enum': 'MigrationCapability',
-  'data': ['xbzrle'] }
+  'data': ['xbzrle', 'x-chunk-register-destination'] }
But given the x- prefix, which is already a designation that the option
is experimental and may be pulled, I can live without documentation here
(where JUST the RDMA documentation, which mentions this capability, is
sufficient).  Therefore:

Reviewed-by: Eric Blake <address@hidden>


My apologies - I'm more than happy to add documentation.

Will include in next patch.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]