Re: [Qemu-devel] [RFC/PATCH 0/1] cpu hotplug for s390

[Andreas Färber]

Hi Jens,

Am 03.04.2013 08:42, schrieb Jens Freimann:
> this is what our approach to CPU hotplug looks like.
> With respect to Igor's CPU hotplug series, how should we proceed? 
> Should we change the interface to 
> qemu_system_cpu_add_notifier/qemu_system_cpu_hotplug_request/cpu-add etc?

I am wondering if my recent qdev/device_add fixes would allow to
implement CPU hot-add via device_add for s390x?

Background is that for x86 we currently have a flat CPU core/thread
namespace but would need to deal with sockets, cores and threads to get
topologies right. I assume there are no such issues on s390x, so that
the vCPU to CPUState mapping could stay 1:1?

> Feedback regarding the non-API part is also highly welcome!

I did spot some QOM'ish nitpicks in the qdev_create() but I am wondering
if you and Alex see an urgent need to get this into 1.5 during the Soft
Freeze or whether we can just align it to x86 work for now and deal with
it after the release?

Regards,
Andreas

> Thang Pham (1):
>   s390: implement CPU hotplug
> 
>  hmp-commands.hx           |  14 +++++
>  hw/s390x/Makefile.objs    |   2 +-
>  hw/s390x/event-facility.c |   9 ++++
>  hw/s390x/event-facility.h |   3 ++
>  hw/s390x/s390-virtio.c    |  34 +++++++++---
>  hw/s390x/sclp.c           | 134 
> +++++++++++++++++++++++++++++++++++++++++++++-
>  hw/s390x/sclp.h           |  47 +++++++++++++++-
>  include/sysemu/sysemu.h   |   1 +
>  monitor.c                 |  31 +++++++++++
>  target-s390x/cpu.c        |  59 ++++++++++++++++++++
>  target-s390x/cpu.h        |   7 +++
>  target-s390x/helper.c     |  43 +++++++++++++++
>  vl.c                      |   6 +++
>  13 files changed, 379 insertions(+), 11 deletions(-)
> 


-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg