Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic

[Michael S. Tsirkin]

The following comment applies to all of this code:

On Wed, Apr 17, 2013 at 07:07:17PM -0400, address@hidden wrote:
> diff --git a/migration-rdma.c b/migration-rdma.c
> new file mode 100644
> index 0000000..1dff06f
> --- /dev/null
> +++ b/migration-rdma.c
> @@ -0,0 +1,2667 @@
> +/*
> + *  Copyright (C) 2013 Michael R. Hines <address@hidden>
> + *  Copyright (C) 2010 Jiuxing Liu <address@hidden>

By the way do you both really hold copyrights on this code?
It's not assigned to IBM?
If the later it should say:
        Copyright IBM
        Author: Michael R. Hines
Or some such.

> + *
> + *  RDMA protocol and interfaces
> + *
> + *  This program is free software; you can redistribute it and/or modify
> + *  it under the terms of the GNU General Public License as published by
> + *  the Free Software Foundation; under version 2 of the License.


We prefer 2 or later for new code.
I'm guessing you need approval from Jiuxing Liu for this,
pls make him ack license change.

> + *
> + *  This program is distributed in the hope that it will be useful,
> + *  but WITHOUT ANY WARRANTY; without even the implied warranty of
> + *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + *  GNU General Public License for more details.
> + *
> + *  You should have received a copy of the GNU General Public License
> + *  along with this program; if not, see <http://www.gnu.org/licenses/>.
> + */