Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic

[Michael R. Hines]

On 04/18/2013 09:06 AM, Michael S. Tsirkin wrote:
> On Thu, Apr 18, 2013 at 09:59:52AM -0400, Michael R. Hines wrote:
> > On 04/18/2013 03:58 AM, Michael S. Tsirkin wrote:
> > > The following comment applies to all of this code:
> > >
> > > On Wed, Apr 17, 2013 at 07:07:17PM -0400, address@hidden wrote:
> > > > diff --git a/migration-rdma.c b/migration-rdma.c
> > > > new file mode 100644
> > > > index 0000000..1dff06f
> > > > --- /dev/null
> > > > +++ b/migration-rdma.c
> > > > @@ -0,0 +1,2667 @@
> > > > +/*
> > > > + *  Copyright (C) 2013 Michael R. Hines <address@hidden>
> > > > + *  Copyright (C) 2010 Jiuxing Liu <address@hidden>
> > > By the way do you both really hold copyrights on this code?
> > > It's not assigned to IBM?
> > > If the later it should say:
> > >         Copyright IBM
> > >         Author: Michael R. Hines
> > > Or some such.
> > Acknowledged.
> >
> > > > + *
> > > > + *  RDMA protocol and interfaces
> > > > + *
> > > > + *  This program is free software; you can redistribute it and/or modify
> > > > + *  it under the terms of the GNU General Public License as published by
> > > > + *  the Free Software Foundation; under version 2 of the License.
> > > We prefer 2 or later for new code.
> > Doesn't it say version 2 already?
> version 2 != 'version 2 or later'. See COPYING at the top level in qemu.

I'll duplicate the copyright used in Anthony's migration.c and tailor it 
to match.

> > > I'm guessing you need approval from Jiuxing Liu for this,
> > > pls make him ack license change.
> > He approves. He doesn't work for IBM anymore.
> Does he approve version 2 or version 2 or later?

It doesn't matter - his contributions were made at IBM and he doesn't 
work for IBM anymore.