Re: [Qemu-devel] [PATCH for-1.5 v2 06/15] xilinx_spips: Trash LQ page cache on mode change

[Peter Maydell]

On 19 April 2013 03:06,  <address@hidden> wrote:
> From: Peter Crosthwaite <address@hidden>
>
> Invalidate the LQSPI cached page when transitioning into LQSPI mode.
> Otherwise there is a possibility that the controller will return stale
> data to the guest when transitioning back to LQ_MODE after a page
> program.
>
> Signed-off-by: Peter Crosthwaite <address@hidden>
> ---
> changed from v1:
> Re-implemented using separate SPI/QSPI write handlers.
>
>  hw/ssi/xilinx_spips.c |   26 +++++++++++++++++++++++++-
>  1 files changed, 25 insertions(+), 1 deletions(-)
>
> diff --git a/hw/ssi/xilinx_spips.c b/hw/ssi/xilinx_spips.c
> index e351cb2..6d38111 100644
> --- a/hw/ssi/xilinx_spips.c
> +++ b/hw/ssi/xilinx_spips.c
> @@ -165,6 +165,8 @@ typedef struct {
>  typedef struct XilinxSPIPSClass {
>      SysBusDeviceClass parent_class;
>
> +    const MemoryRegionOps *reg_ops;
> +
>      uint32_t rx_fifo_size;
>      uint32_t tx_fifo_size;
>  } XilinxSPIPSClass;
> @@ -446,6 +448,7 @@ static void xilinx_spips_write(void *opaque, hwaddr addr,
>      case R_TXD3:
>          tx_data_bytes(s, (uint32_t)value, 3);
>          goto no_reg_update;
> +        break;

Why insert code after a goto?

>      }
>      s->regs[addr] = (s->regs[addr] & ~mask) | (value & mask);
>  no_reg_update:

-- PMM