[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/5] vmdk: add bdrv_co_write_zeroes
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH 5/5] vmdk: add bdrv_co_write_zeroes |
Date: |
Fri, 19 Apr 2013 19:04:27 +0800 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, 04/19 11:12, Stefan Hajnoczi wrote:
> On Fri, Apr 19, 2013 at 11:48:45AM +0800, Fam Zheng wrote:
> > From: Feiran Zheng <address@hidden>
> >
> > Use special offset to write zeroes efficiently, when zeroed-grain GTE is
> > available. If zero-write an allocated cluster, cluster is leaked because
> > its offset pointer is overwritten by "0x1".
> >
> > Signed-off-by: Fam Zheng <address@hidden>
> > ---
> > block/vmdk.c | 63
> > +++++++++++++++++++++++++++++++++++++++++++++++-------------
> > 1 file changed, 50 insertions(+), 13 deletions(-)
>
> Do existing qemu-iotests zero write tests cases cover this? Do you need
> to add vmdk to their list of supported formats?
I guess they cover and has include vmdk already, need to double check
correctness of both side and fix the multiple extents cases
(twoGbMaxExtent{Sparse,Flat}).
This patch can't properly handle metadata update for zero write, will
fix in next version.
--
Fam
- [Qemu-devel] [PATCH 2/5] vmdk: add support for “zeroed‐grain” GTE, (continued)
[Qemu-devel] [PATCH 3/5] vmdk: Add option to create zeroed-grain image, Fam Zheng, 2013/04/18
[Qemu-devel] [PATCH 4/5] vmdk: change magic number to macro, Fam Zheng, 2013/04/18
[Qemu-devel] [PATCH 5/5] vmdk: add bdrv_co_write_zeroes, Fam Zheng, 2013/04/18