[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] tcg: Remove temp_buf
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH] tcg: Remove temp_buf |
Date: |
Fri, 19 Apr 2013 14:11:15 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 |
Hi,
Am 19.04.2013 10:27, schrieb Richard Henderson:
> All targets have been converted to allocating space for temporaries
> on the stack. No need to allocate space within the CPU_COMMON block.
>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
> This depends on my tcg-arm patch set that's still outstanding.
My tree still has exactly one user in tcg/arm/, so once that disappears
feel free to add my Reviewed-by. Thanks for helping clean this up!
One question...
>
>
> r~
> ---
> include/exec/cpu-defs.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/exec/cpu-defs.h b/include/exec/cpu-defs.h
> index d8c64e9..41f5b32 100644
> --- a/include/exec/cpu-defs.h
> +++ b/include/exec/cpu-defs.h
> @@ -152,8 +152,6 @@ typedef struct CPUWatchpoint {
> memory was accessed */ \
> CPU_COMMON_TLB \
> struct TranslationBlock *tb_jmp_cache[TB_JMP_CACHE_SIZE]; \
> - /* buffer for temporaries in the code generator */ \
> - long temp_buf[CPU_TEMP_BUF_NLONGS]; \
Could CPU_TEMP_BUF_NLONGS be removed, too?
Andreas
> \
> int64_t icount_extra; /* Instructions until next timer event. */ \
> /* Number of cycles left, with interrupt flag in high bit. \
>
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg