[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RfC PATCH 0/5] console: qom-ify & extent screendump mo
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [RfC PATCH 0/5] console: qom-ify & extent screendump monitor command |
Date: |
Fri, 19 Apr 2013 07:03:00 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130402 Thunderbird/17.0.5 |
On 04/19/2013 02:37 AM, Markus Armbruster wrote:
>> Question for the libvirt guys: Is it ok for libvirt to just extend the
>> existing screendump command? Can libvirt figure there is a new
>> (optional) parameter? See patch #5.
>
> Nope, QMP can't do that. I argued for such capabilities, but the
> "create a new command" philosophy prevailed.
>
> Go forth and multiply commands! And have fun picking command names that
> aren't fugly.
Adding optional parameters to an existing command has been done before;
drive-mirror gained 'granularity' and 'buf-size' in 1.4 even though the
command existed in 1.3.
What would make it possible to avoid an explosion of new commands is a
way to introspect WHICH options are available for a given command. We
don't have that yet, but if we add a command that returns the JSON
representation of what the command expects, THAT would make it
acceptable to add optional arguments to an existing command in a way
that libvirt could query to see whether the qemu it is talking to
supports the optional arguments.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 2/5] console: Hook QemuConsoles into qom tree, (continued)
- [Qemu-devel] [PATCH 2/5] console: Hook QemuConsoles into qom tree, Gerd Hoffmann, 2013/04/18
- [Qemu-devel] [PATCH 4/5] console: add qemu_console_lookup_by_device, Gerd Hoffmann, 2013/04/18
- [Qemu-devel] [PATCH 1/5] console: qom-ify QemuConsole, Gerd Hoffmann, 2013/04/18
- [Qemu-devel] [PATCH 5/5] console: extend screendump monitor cmd, Gerd Hoffmann, 2013/04/18
- [Qemu-devel] [PATCH 3/5] console: add device link to QemuConsoles, Gerd Hoffmann, 2013/04/18
- Re: [Qemu-devel] [RfC PATCH 0/5] console: qom-ify & extent screendump monitor command, Eric Blake, 2013/04/18
- Re: [Qemu-devel] [RfC PATCH 0/5] console: qom-ify & extent screendump monitor command, Markus Armbruster, 2013/04/19
- Re: [Qemu-devel] [RfC PATCH 0/5] console: qom-ify & extent screendump monitor command,
Eric Blake <=
- Re: [Qemu-devel] [RfC PATCH 0/5] console: qom-ify & extent screendump monitor command, Gerd Hoffmann, 2013/04/22
- Re: [Qemu-devel] [RfC PATCH 0/5] console: qom-ify & extent screendump monitor command, Paolo Bonzini, 2013/04/22
- Re: [Qemu-devel] [RfC PATCH 0/5] console: qom-ify & extent screendump monitor command, Luiz Capitulino, 2013/04/22
- Re: [Qemu-devel] [RfC PATCH 0/5] console: qom-ify & extent screendump monitor command, Paolo Bonzini, 2013/04/22
- Re: [Qemu-devel] [RfC PATCH 0/5] console: qom-ify & extent screendump monitor command, Anthony Liguori, 2013/04/22
- Re: [Qemu-devel] [RfC PATCH 0/5] console: qom-ify & extent screendump monitor command, Paolo Bonzini, 2013/04/22
- Re: [Qemu-devel] [RfC PATCH 0/5] console: qom-ify & extent screendump monitor command, Eric Blake, 2013/04/22
- Re: [Qemu-devel] [RfC PATCH 0/5] console: qom-ify & extent screendump monitor command, Gerd Hoffmann, 2013/04/23
- Re: [Qemu-devel] [RfC PATCH 0/5] console: qom-ify & extent screendump monitor command, Anthony Liguori, 2013/04/22
- Re: [Qemu-devel] [RfC PATCH 0/5] console: qom-ify & extent screendump monitor command, Gerd Hoffmann, 2013/04/23