qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] tcg: Remove temp_buf


From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH] tcg: Remove temp_buf
Date: Sat, 20 Apr 2013 10:00:02 -0700
User-agent: Mozilla/5.0 (X11; Linux armv7l; rv:17.0) Gecko/20130319 Thunderbird/17.0.4

On 04/20/2013 03:46 AM, Blue Swirl wrote:
On Fri, Apr 19, 2013 at 12:18 PM, Andreas Färber <address@hidden> wrote:
Am 19.04.2013 14:11, schrieb Andreas Färber:
Hi,

Am 19.04.2013 10:27, schrieb Richard Henderson:
All targets have been converted to allocating space for temporaries
on the stack.  No need to allocate space within the CPU_COMMON block.

Signed-off-by: Richard Henderson <address@hidden>
---
This depends on my tcg-arm patch set that's still outstanding.
My tree still has exactly one user in tcg/arm/, so once that disappears
feel free to add my Reviewed-by. Thanks for helping clean this up!

One question...


r~
---
  include/exec/cpu-defs.h | 2 --
  1 file changed, 2 deletions(-)

diff --git a/include/exec/cpu-defs.h b/include/exec/cpu-defs.h
index d8c64e9..41f5b32 100644
--- a/include/exec/cpu-defs.h
+++ b/include/exec/cpu-defs.h
@@ -152,8 +152,6 @@ typedef struct CPUWatchpoint {
                                       memory was accessed */             \
      CPU_COMMON_TLB                                                      \
      struct TranslationBlock *tb_jmp_cache[TB_JMP_CACHE_SIZE];           \
-    /* buffer for temporaries in the code generator */                  \
-    long temp_buf[CPU_TEMP_BUF_NLONGS];                                 \
Could CPU_TEMP_BUF_NLONGS be removed, too?
More precisely, seeing that all targets actually still use it despite in
most cases not actually accessing temp_buf, can you rename it to
TCG_TEMP_STACK_NLONGS and move it to some TCG header as a follow-up please?
Much like this patch?

http://lists.nongnu.org/archive/html/qemu-devel/2011-05/msg03086.html

Yes, that would be the one...


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]