Re: [Qemu-devel] [PATCH] tcg: fix deposit_i64 op on 32-bit targets

[Richard Henderson]

On 2013-04-21 00:48, Aurelien Jarno wrote:
> On 32-bit TCG targets, when emulating deposit_i64 with a mov_i32 +
> deposit_i32, care should be taken to not overwrite the low part of
> the second argument before the deposit when it is the same the
> destination.
>
> This fixes the shld instruction in qemu-system-x86_64, which in turns
> fixes booting "system rescue CD version 2.8.0" on this target.
>
> Reported-by: Michael S. Tsirkin<address@hidden>
> Cc: Richard Henderson<address@hidden>
> Cc: Paolo Bonzini<address@hidden>
> Signed-off-by: Aurelien Jarno<address@hidden>

Nice catch.

Reviewed-by: Richard Henderson <address@hidden>


r~