[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] win32: add readv/writev emulation
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/2] win32: add readv/writev emulation |
|
Date: |
Tue, 23 Apr 2013 20:22:51 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 |
> Hi Paolo,
>
> your patch looks good, but maybe you could modify the signatures
> of readv, writev to match the Linux originals (missing const, use int):
>
> ssize_t readv(int fd, const struct iovec *iov, int iovcnt);
> ssize_t writev(int fd, const struct iovec *iov, int iovcnt);
>
> In an updated patch the tab characters could be replaced by a space
> to make checkpatch.pl happy.
Ok, I'll send it tomorrow. I'll make a pull request myself to
streamline the process in time for -rc0.
Paolo