qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v5 00/12] rdma: migration support


From: Michael R. Hines
Subject: Re: [Qemu-devel] [PATCH v5 00/12] rdma: migration support
Date: Tue, 23 Apr 2013 14:46:46 -0400
User-agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130106 Thunderbird/17.0.2

On 04/23/2013 02:26 PM, Anthony Liguori wrote:
"Michael R. Hines" <address@hidden> writes:

On 04/23/2013 01:50 PM, Anthony Liguori wrote:
address@hidden writes:

From: "Michael R. Hines" <address@hidden>

Juan, Please pull.
I assume this is actually v6, not v5?

I don't see collected Reviewed-bys...

That said, we're pretty close to hard freeze.  I think this should wait
until 1.6 opens up although I'm open to suggestion if people think this
is low risk.  I don't like the idea of adding a new protocol this close
to the end of a cycle.

Regards,

Anthony Liguori
There are no instructions/procedures documented on the qemu.org
website on how to automatically generate "Reviewed-by" signatures.
I suspect there's some confusion here.  Addressed review comments !=
Reviewed-by.  There can always be additional comments.  Someone has to
explicitly offer a Reviewed-by indicating that they are happy with the
patches overall.  I've gone through the history on these patches and I
don't see any explicit Reviewed-by's other than Eric's most recent one.

Give the series a little more time for people to look over it, it'll get
Reviewed-bys when people are ready to offer them.

Ah, OK, so then when I receive the signatures by email, do
I just literally "paste" the Reviewed-By directly into the patch series by hand?

Is this not handled by git?

- Michael




reply via email to

[Prev in Thread] Current Thread [Next in Thread]