qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 5/5] block: add header update capability for


From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [PATCH v2 5/5] block: add header update capability for VHDX images.
Date: Thu, 25 Apr 2013 09:20:14 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

On Wed, Apr 24, 2013 at 10:56:19AM -0400, Jeff Cody wrote:
> On Wed, Apr 24, 2013 at 04:47:15PM +0200, Stefan Hajnoczi wrote:
> > On Tue, Apr 23, 2013 at 10:24:24AM -0400, Jeff Cody wrote:
> > > This adds the ability to update the headers in a VHDX image, including
> > > generating a new MS-compatible GUID.
> > > 
> > > As VHDX depends on uuid.h, VHDX is now a configurable build option.
> > > If VHDX support is enabled, that will also enable uuid as well.
> > > 
> > > To enable/disable VHDX:  --enable-vhdx, --disable-vhdx
> > > 
> > > Signed-off-by: Jeff Cody <address@hidden>
> > > ---
> > >  block/Makefile.objs |   2 +-
> > >  block/vhdx.c        | 157 
> > > +++++++++++++++++++++++++++++++++++++++++++++++++++-
> > >  configure           |  13 +++++
> > >  3 files changed, 169 insertions(+), 3 deletions(-)
> > 
> > Why is this part of the series?
> > 
> > Stefan
> 
> This could technically be dropped from the series, since the current
> series only supports r/o functions.   
> 
> I included it because it is not log-dependent - This patch provides
> the basic mechanism to update the headers (header updates do not go
> through the log), so it is safe. It is not required yet, but it will
> be in the future.

I suggest putting this patch into the series that makes use of it.

Stefan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]