Re: [Qemu-devel] [PATCH] Remove unnecessary FreeBSD #include

[Peter Maydell]

On 25 April 2013 17:17, Ed Maste <address@hidden> wrote:
> sys/param.h was included to define __FreeBSD_version, but the conditional
> using it was removed by commit d05ef160453e98546a4197496dc8a3cb2defac53
> (Brad Smith, "Allow clock_gettime() monotonic clock to be utilized on more
> OS's"), so the include is no longer needed here.
>
> Signed-off-by: Ed Maste <address@hidden>

CCing qemu-trivial for this.

(Our other use of __FreeBSD_version is preceded by a direct
include of sys/param.h in translate-all.c.)

Reviewed-by: Peter Maydell <address@hidden>

thanks
-- PMM

> ---
>  include/qemu/timer.h | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/include/qemu/timer.h b/include/qemu/timer.h
> index c363190..9dd206c 100644
> --- a/include/qemu/timer.h
> +++ b/include/qemu/timer.h
> @@ -5,10 +5,6 @@
>  #include "qemu/main-loop.h"
>  #include "qemu/notify.h"
>
> -#ifdef __FreeBSD__
> -#include <sys/param.h>
> -#endif
> -
>  /* timers */
>
>  #define SCALE_MS 1000000
> --
> 1.7.11.5
>