[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Remove unnecessary FreeBSD #include
|
From: |
Ed Maste |
|
Subject: |
Re: [Qemu-devel] [PATCH] Remove unnecessary FreeBSD #include |
|
Date: |
Thu, 25 Apr 2013 13:13:13 -0400 |
On 25 April 2013 12:59, Peter Maydell <address@hidden> wrote:
> (Our other use of __FreeBSD_version is preceded by a direct
> include of sys/param.h in translate-all.c.)
I noticed that one. It's checking for __FreeBSD_version >= 700104,
which corresponds to a point in time a little before the 7.1 release.
Since that's no longer supported the conditional can be removed at
some point, although there's no urgency as it doesn't cause any
trouble. The timer.h one resulted in a broken build, since it ended
up bringing in a round_page macro definition which conflicted with a
function of the same name in mac_{old,new}world.c.