[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/4 v4] Support for LED state extension to Qemu
From: |
Anthony Liguori |
Subject: |
Re: [Qemu-devel] [PATCH 0/4 v4] Support for LED state extension to Qemu VNC server |
Date: |
Thu, 25 Apr 2013 14:40:49 -0500 |
User-agent: |
Notmuch/0.15.2+77~g661dcf8 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) |
Lei Li <address@hidden> writes:
> Hi guys,
>
> This patch series tries to add support for LED state
> extension to Qemu VNC server. The proposal has been sent
> few days ago as link below:
>
> http://lists.gnu.org/archive/html/qemu-devel/2013-04/msg01421.html
>
> The previous version as link:
>
> http://lists.nongnu.org/archive/html/qemu-devel/2013-04/msg04773.html
>
> Pleae let me know if there is anything else need be improved.
>
> Thanks!
Reviewed-by: Anthony Liguori <address@hidden>
I'll give people some time to take a look before applying but it looks good to
me.
Regards,
Anthony Liguori
>
>
> Changes since v3:
> - Add adjustment of turning off lock state sync logic in do_key_event()
> when VNC_FEATURE_LED_STATE supported suggested by Gerd.
> - Document improvement suggested by Eric.
>
> Changes since v2:
> - Address the comments from Anthony includes:
> - Just send 1 instead of the actual width and height.
> - Improve the document by adding the Pseudo-encoding number
> and simplify the description of the LED state encoding.
>
> Changes since v1:
> - Address the comments from Anthony includes:
> - Use Pseudo-encoding for led state;
> - Get rid of send_ext_leds_state_ack;
> - Add document for the led state Pseudo-encoding.
>
> Lei Li (4):
> vnc: Add SCROLL lock key to kbd_leds
> vnc: Support for LED state extension
> vnc: Adjust lock state sync logic with VNC_FEATURE_LED_STATE
> doc: document the Pseudo-encoding of LED state
>
> docs/vnc-ledstate-Pseudo-encoding.txt | 50 +++++++++++++++++++++++++++++
> ui/vnc.c | 56
> ++++++++++++++++++++++++++++++++-
> ui/vnc.h | 3 ++
> 3 files changed, 108 insertions(+), 1 deletions(-)
> create mode 100644 docs/vnc-ledstate-Pseudo-encoding.txt
- [Qemu-devel] [PATCH 0/4 v4] Support for LED state extension to Qemu VNC server, Lei Li, 2013/04/25
- [Qemu-devel] [PATCH 1/4] vnc: Add SCROLL lock key to kbd_leds, Lei Li, 2013/04/25
- [Qemu-devel] [PATCH 3/4] vnc: Adjust lock state sync logic with VNC_FEATURE_LED_STATE, Lei Li, 2013/04/25
- [Qemu-devel] [PATCH 2/4] vnc: Support for LED state extension, Lei Li, 2013/04/25
- [Qemu-devel] [PATCH 4/4] doc: document the Pseudo-encoding of LED state, Lei Li, 2013/04/25
- Re: [Qemu-devel] [PATCH 0/4 v4] Support for LED state extension to Qemu VNC server,
Anthony Liguori <=
- Re: [Qemu-devel] [PATCH 0/4 v4] Support for LED state extension to Qemu VNC server, Anthony Liguori, 2013/04/29