[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] rbd: Fix use after free in rbd_open()
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH] rbd: Fix use after free in rbd_open() |
|
Date: |
Fri, 26 Apr 2013 10:16:49 +0200 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Thu, Apr 25, 2013 at 03:59:27PM +0200, Kevin Wolf wrote:
> Commit 56d1b4d2 frees the QemuOpts for the driver-specific options
> immediately, even though it still needs the filename string that is
> contained there. This doesn't work. Move the deletion of the QemuOpts to
> the end of the function where its content isn't needed any more.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block/rbd.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan