[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] ich9: kill cmos_s3
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH] ich9: kill cmos_s3 |
|
Date: |
Fri, 26 Apr 2013 10:38:41 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 |
Il 24/04/2013 20:49, Andreas Färber ha scritto:
> Am 24.04.2013 13:30, schrieb Paolo Bonzini:
>> Il 24/04/2013 12:37, Hu Tao ha scritto:
>>> Signed-off-by: Hu Tao <address@hidden>
>>
>> I had exactly the same patch in my 1.6 queue. :)
>>
>> Reviewed-by: Paolo Bonzini <address@hidden>
>
> The commit message fails to explain *why* we can drop updating whatever
> RTC memory value there though?
Ultimately the argument was unused (see the ich9_pm_init part of the
patch). This is now done with
s->suspend_notifier.notify = rtc_notify_suspend;
qemu_register_suspend_notifier(&s->suspend_notifier);
in hw/timer/mc146818rtc.c.
Paolo