[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v5 04/14] net: port vde onto GSource
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [RFC PATCH v5 04/14] net: port vde onto GSource |
|
Date: |
Fri, 26 Apr 2013 11:25:12 +0200 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, Apr 26, 2013 at 10:47:25AM +0800, Liu Ping Fan wrote:
> +static gboolean vde_handler(gpointer data)
> +{
> + EventGSource *nsrc = (EventGSource *)data;
> +
> + if (nsrc->gfd.revents & G_IO_IN) {
The VDE file descriptor is a socket. Please use the full G_IO_IN |
G_IO_HUP | G_IO_ERR set which is equivalent to select(2) rfds. This
ensures we handle errors and disconnect.
- [Qemu-devel] [RFC PATCH v5 00/14] port network layer onto glib, Liu Ping Fan, 2013/04/25
- [Qemu-devel] [RFC PATCH v5 02/14] net: introduce bind_ctx to NetClientInfo, Liu Ping Fan, 2013/04/25
- [Qemu-devel] [RFC PATCH v5 03/14] net: port tap onto GSource, Liu Ping Fan, 2013/04/25
- [Qemu-devel] [RFC PATCH v5 04/14] net: port vde onto GSource, Liu Ping Fan, 2013/04/25
- Re: [Qemu-devel] [RFC PATCH v5 04/14] net: port vde onto GSource,
Stefan Hajnoczi <=
- [Qemu-devel] [RFC PATCH v5 05/14] net: port socket to GSource, Liu Ping Fan, 2013/04/25
[Qemu-devel] [RFC PATCH v5 06/14] net: port tap-win32 onto GSource, Liu Ping Fan, 2013/04/25
[Qemu-devel] [RFC PATCH v5 07/14] net: hub use lock to protect ports list, Liu Ping Fan, 2013/04/25
[Qemu-devel] [RFC PATCH v5 08/14] net: introduce lock to protect NetQueue, Liu Ping Fan, 2013/04/25
[Qemu-devel] [RFC PATCH v5 09/14] net: introduce lock to protect NetClientState's peer's access, Liu Ping Fan, 2013/04/25
[Qemu-devel] [RFC PATCH v5 10/14] net: make netclient re-entrant with refcnt, Liu Ping Fan, 2013/04/25
[Qemu-devel] [RFC PATCH v5 11/14] slirp: make timeout local, Liu Ping Fan, 2013/04/25