Re: [Qemu-devel] [PATCH v2] microblaze: Add internal base vectors reg

[Edgar E. Iglesias]

On Fri, Apr 26, 2013 at 01:48:45PM +0200, Andreas Färber wrote:
> Hi,
> 
> Am 24.04.2013 13:31, schrieb address@hidden:
> > From: "Edgar E. Iglesias" <address@hidden>
> > 
> > Configurable at CPU synthesis/instantiation.
> > 
> > Signed-off-by: Edgar E. Iglesias <address@hidden>
> > ---
> > 
> > Peter Crosthwaite commented off-list that it would be a good idea
> > to make this a device property. I agree but am a bit unsure of
> > how it should look. Any comments on this attempt?
> > 
> > v2:
> > Make base_vectors a CPU/device property.
> 
> The patch looks good, expect that I don't see any machine or subclass
> setting that property?
> 
> If you want to use it from the command line, you would either need to
> add custom parsing code to -cpu, use -global or dive into experimenting
> with -device <your-cpu-type>,xlnx.base-vectors=value. Me at least I have
> been preparing this through code review and fixes but not yet actually
> tried it for some QOM'ified target since x86 isn't yet.

Hi Andreas,

Right, the use of the property is currently out of tree.

The MicroBlaze core has tons of options that are set at synthesis time.
We currently support lots of variations in QEMU allthough only one or
two are used by machines in upstream. The CPU model looks at the version
regs (PVR) to check for features. Machines need to setup up PVRs according
to the CPU setup they emulate.

Now that CPUs can have qom props, we can make PVR regs optional and no
longer dictate the feature set.

Cheers,
Edgar