[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] virtio: abort on zero config length
From: |
Anthony Liguori |
Subject: |
Re: [Qemu-devel] [PATCH] virtio: abort on zero config length |
Date: |
Fri, 26 Apr 2013 09:13:55 -0500 |
User-agent: |
Notmuch/0.15.2+77~g661dcf8 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) |
"Michael S. Tsirkin" <address@hidden> writes:
> On Fri, Apr 26, 2013 at 06:33:33PM +0800, Jason Wang wrote:
>> On 04/26/2013 06:32 PM, Eric Blake wrote:
>> > On 04/25/2013 11:06 PM, Jason Wang wrote:
>> >>>> if (addr > (vdev->config_len - sizeof(val)))
>> >>>>
>> >>>> ^^^^^^^^^ quiz: spot a bug above if config_len is 0 :)
>> >>> Then we need to fix these bugs and allocate a CVE. virtio-rng has
>> >>> shipped. This code is also dumb.
>> >> Ok, but since the discussion is in public list, no need for CVE then.
>> > Wrong. CVEs are useful even for publicly disclosed bugs. It tells
>> > people whether they need to upgrade in order to avoid a vulnerability.
>> >
>> > What we don't need is embargo. But we do need a CVE.
>> >
>>
>> True, thanks for the correction.
>
> I think we never shipped QEMU release with this bug. So no need for
> CVEs. I'm not sure upstream has to bother with CVEs - we can just say
> this is downstream work.
Uh, we certainly do. QEMU 1.4 had virtio-rng and therefore had this bug
so we need to allocate a CVE.
Regards,
Anthony Liguori
>
> --
> MST
- [Qemu-devel] [PATCH] virtio: abort on zero config length, Jason Wang, 2013/04/25
- Re: [Qemu-devel] [PATCH] virtio: abort on zero config length, Michael S. Tsirkin, 2013/04/25
- Re: [Qemu-devel] [PATCH] virtio: abort on zero config length, Anthony Liguori, 2013/04/25
- Re: [Qemu-devel] [PATCH] virtio: abort on zero config length, Michael S. Tsirkin, 2013/04/25
- Re: [Qemu-devel] [PATCH] virtio: abort on zero config length, Anthony Liguori, 2013/04/25
- Re: [Qemu-devel] [PATCH] virtio: abort on zero config length, Jason Wang, 2013/04/26
- Re: [Qemu-devel] [PATCH] virtio: abort on zero config length, Eric Blake, 2013/04/26
- Re: [Qemu-devel] [PATCH] virtio: abort on zero config length, Jason Wang, 2013/04/26
- Re: [Qemu-devel] [PATCH] virtio: abort on zero config length, Michael S. Tsirkin, 2013/04/26
- Re: [Qemu-devel] [PATCH] virtio: abort on zero config length,
Anthony Liguori <=
- Re: [Qemu-devel] [PATCH] virtio: abort on zero config length, Laszlo Ersek, 2013/04/26