[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qdev: Report errors collected during device rea
|
From: |
Andreas Färber |
|
Subject: |
Re: [Qemu-devel] [PATCH] qdev: Report errors collected during device realization |
|
Date: |
Mon, 29 Apr 2013 16:31:14 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 |
Am 29.04.2013 14:35, schrieb Jan Kiszka:
> Better than just releasing the error object silently.
>
> Signed-off-by: Jan Kiszka <address@hidden>
Reviewed-by: Andreas Färber <address@hidden>
but CC'ing monitor guys to verify this is the right print function.
Andreas
> ---
> hw/core/qdev.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/hw/core/qdev.c b/hw/core/qdev.c
> index 4eb0134..ab1d8f5 100644
> --- a/hw/core/qdev.c
> +++ b/hw/core/qdev.c
> @@ -162,6 +162,7 @@ int qdev_init(DeviceState *dev)
>
> object_property_set_bool(OBJECT(dev), true, "realized", &local_err);
> if (local_err != NULL) {
> + qerror_report_err(local_err);
> error_free(local_err);
> qdev_free(dev);
> return -1;
>
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg