qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH] QOM: Fail casts for unknown types


From: Alexander Graf
Subject: [Qemu-devel] [PATCH] QOM: Fail casts for unknown types
Date: Tue, 30 Apr 2013 15:02:16 +0200

When we try to cast an object to an unknown type, fail the cast. Today
we would simply run into an assert().

This fixes a bug on qemu-system-s390x for me that gets triggered by the
audio code looking for PCI and ISA buses.

Signed-off-by: Alexander Graf <address@hidden>
---
 qom/object.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/qom/object.c b/qom/object.c
index dd53d24..75e6aac 100644
--- a/qom/object.c
+++ b/qom/object.c
@@ -453,6 +453,11 @@ ObjectClass *object_class_dynamic_cast(ObjectClass *class,
     TypeImpl *type = class->type;
     ObjectClass *ret = NULL;
 
+    if (!target_type) {
+        /* target class type unknown, so fail the cast */
+        return NULL;
+    }
+
     if (type->class->interfaces &&
             type_is_ancestor(target_type, type_interface)) {
         int found = 0;
-- 
1.6.0.2




reply via email to

[Prev in Thread] Current Thread [Next in Thread]