Re: [Qemu-devel] [PATCH] target-arm: cpu: set default cpu_model via QEMUMachine.cpu_model

[Igor Mammedov]

On Tue, 30 Apr 2013 15:55:24 +0100
Peter Maydell <address@hidden> wrote:

> On 30 April 2013 15:48, Igor Mammedov <address@hidden> wrote:
> > Signed-off-by: Igor Mammedov <address@hidden>
> > ---
> >  compile tested only ...
> >
> > ---
> >  hw/arm/realview.c    |   16 ++++------------
> >  hw/arm/versatilepb.c |    5 ++---
> 
> Anything that's only touching these two boards is clearly
> not considering the whole situation -- more boards than
> just these two have a board specific default CPU.
that was only ones that used QEMUMachineArgs.cpu_model as storage for
dynamically setting default value. 
Other machines should be checked and cleaned up as well.

perhaps commit subj should be:
target-arm: cpu: set default cpu_model via QEMUMachine.cpu_model for realview 
and versatilepb boards.
> 
> thanks
> -- PMM