|
From: | Richard Henderson |
Subject: | Re: [Qemu-devel] qemu/virtio issue due to non-atomic data access |
Date: | Thu, 02 May 2013 11:06:15 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130402 Thunderbird/17.0.5 |
On 2013-05-02 10:12, Paul Guo wrote:
A proper fix for this issue seems to be: Judge whether the address is aligned, do direct loading for the aligned case in ldq_le_p(), etc?
No, I would think the proper fix would be to change the bits of virtio that are known to access aligned memory to not use the pointer wrapper functions, but to use a normal C memory access followed by leN_to_cpu et al.
r~
[Prev in Thread] | Current Thread | [Next in Thread] |