Re: [Qemu-devel] posting patches in pull requests (was Re: [PATCH 08/29] cpu: Add qemu_for_each_cpu())

[Andreas Färber]

Am 02.05.2013 18:08, schrieb Peter Maydell:
> On 2 May 2013 16:59, Andreas Färber <address@hidden> wrote:
>> Am 02.05.2013 16:57, schrieb Peter Maydell:
>>> Wow, you trust get_maintainer.pl that much? IME it
>>> tends to give a huge pile of useless cc suggestions.
>>
>> Useless? It's based on MAINTAINERS, which I expect maintainers to keep
>> up-to-date if they no longer want to maintain something. It's rather
>> that new files don't get entries and thus too few CCs at times IME.
> 
> The ccs based on MAINTAINERS are fine -- it's the random
> extras it picks based on other people who've made patches
> to the same files in the past that are usually wrong.
> For example I tried running it on a patch to MAINTAINERS
> itself, and it suggested ccing you, Alex, Stefan H,
> Peter Crosthwaite and Edgar, which is a random mishmash
> and doesn't include the key person you actually need
> to CC, ie Anthony.

That's why Gerd correctly wrote scripts/get_maintainer.pl
--nogit-fallback - it doesn't do what you claim, although the default does.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg