[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qemu-iotests: Filter out vmdk creation options
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH] qemu-iotests: Filter out vmdk creation options |
Date: |
Fri, 3 May 2013 15:30:26 +0800 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, 05/03 08:48, Kevin Wolf wrote:
> Am 03.05.2013 um 03:31 hat Fam Zheng geschrieben:
> > Cover new image creation options for vmdk, so we can use '-o
> > zeroed_grain=XXX' and '-o subformat=XXX' to run the tests successfully.
> > Signed-off-by: Fam Zheng <address@hidden>
> > ---
> > tests/qemu-iotests/common.rc | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.rc
> > index a536bf7..442cf51 100644
> > --- a/tests/qemu-iotests/common.rc
> > +++ b/tests/qemu-iotests/common.rc
> > @@ -127,6 +127,8 @@ _make_test_img()
> > -e "s# compat='[^']*'##g" \
> > -e "s# compat6=\\(on\\|off\\)##g" \
> > -e "s# static=\\(on\\|off\\)##g" \
> > + -e "s# zeroed_grain=\\(on\\|off\\)##g" \
> > + -e "s# subformat='[^']*'##g" \
> > -e "s# lazy_refcounts=\\(on\\|off\\)##g"
> >
> > # Start an NBD server on the image file, which is what we'll be
> > talking to
>
> Maybe add adapter_type as well? It's a string option, so it's not
> displayed if it's not set, but if we want to make it testable (with an
> explicit ./check -o option or in a new test case that adds it), we need
> to filter it out.
>
> But the patch obviously helps even without adapter_type, so anyway:
>
> Reviewed-by: Kevin Wolf <address@hidden>
Sure, I'll send another patch for that option.
Thanks.
--
Fam