[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 05/15] blockdev: Replace "undefined error" in qmp_bl
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PATCH 05/15] blockdev: Replace "undefined error" in qmp_block_resize |
Date: |
Fri, 3 May 2013 13:52:42 +0200 |
From: Kevin Wolf <address@hidden>
We have an errno value that can be displayed, so we should just do that.
An easy way to reproduce this case is to resize a raw image to a size
that is too large for the host file system.
Signed-off-by: Kevin Wolf <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
blockdev.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index 6e293e9..7c9d8dd 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -1118,6 +1118,7 @@ int do_drive_del(Monitor *mon, const QDict *qdict,
QObject **ret_data)
void qmp_block_resize(const char *device, int64_t size, Error **errp)
{
BlockDriverState *bs;
+ int ret;
bs = bdrv_find(device);
if (!bs) {
@@ -1133,7 +1134,8 @@ void qmp_block_resize(const char *device, int64_t size,
Error **errp)
/* complete all in-flight operations before resizing the device */
bdrv_drain_all();
- switch (bdrv_truncate(bs, size)) {
+ ret = bdrv_truncate(bs, size);
+ switch (ret) {
case 0:
break;
case -ENOMEDIUM:
@@ -1149,7 +1151,7 @@ void qmp_block_resize(const char *device, int64_t size,
Error **errp)
error_set(errp, QERR_DEVICE_IN_USE, device);
break;
default:
- error_set(errp, QERR_UNDEFINED_ERROR);
+ error_setg_errno(errp, -ret, "Could not resize");
break;
}
}
--
1.8.1.4
- [Qemu-devel] [PULL 00/15] Block patches, Stefan Hajnoczi, 2013/05/03
- [Qemu-devel] [PATCH 01/15] qemu: add castagnoli crc32c checksum algorithm, Stefan Hajnoczi, 2013/05/03
- [Qemu-devel] [PATCH 02/15] block: vhdx header for the QEMU support of VHDX images, Stefan Hajnoczi, 2013/05/03
- [Qemu-devel] [PATCH 04/15] block: add read-only support to VHDX image format., Stefan Hajnoczi, 2013/05/03
- [Qemu-devel] [PATCH 03/15] block: initial VHDX driver support framework - supports open and probe, Stefan Hajnoczi, 2013/05/03
- [Qemu-devel] [PATCH 05/15] blockdev: Replace "undefined error" in qmp_block_resize,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH 06/15] vmdk: named return code., Stefan Hajnoczi, 2013/05/03
- [Qemu-devel] [PATCH 07/15] vmdk: add support for “zeroed‐grain” GTE, Stefan Hajnoczi, 2013/05/03
- [Qemu-devel] [PATCH 08/15] vmdk: Add option to create zeroed-grain image, Stefan Hajnoczi, 2013/05/03
- [Qemu-devel] [PATCH 09/15] vmdk: change magic number to macro, Stefan Hajnoczi, 2013/05/03
- [Qemu-devel] [PATCH 10/15] vmdk: store fields of VmdkMetaData in cpu endian, Stefan Hajnoczi, 2013/05/03
- [Qemu-devel] [PATCH 11/15] vmdk: add bdrv_co_write_zeroes, Stefan Hajnoczi, 2013/05/03
- [Qemu-devel] [PATCH 12/15] qemu-iotests: Filter out vmdk creation options, Stefan Hajnoczi, 2013/05/03
- [Qemu-devel] [PATCH 13/15] nbd: use g_slice_new() instead of a freelist, Stefan Hajnoczi, 2013/05/03
- [Qemu-devel] [PATCH 14/15] nbd: support large NBD requests, Stefan Hajnoczi, 2013/05/03
- [Qemu-devel] [PATCH 15/15] qemu-iotests: Filter out 'adapter_type', Stefan Hajnoczi, 2013/05/03