Re: [Qemu-devel] [PATCH v2 09/12] linux-user: Add signal handling for AArch64

[Peter Maydell]

On 30 April 2013 07:38, John Rigby <address@hidden> wrote:
> +    /* set up the stack frame for unwinding */
> +    err |= __put_user(env->xregs[29], &sf->fp);

__put_user can't fail so all this collection of error
status is unnecessary. (Every address we write with it
has to be covered by the lock_user_struct() call which
is where we'll find out if it wasn't writable memory.
Existing code in signal.c that checks __put_user
and __get_user return values is generally cut-n-paste
from the Linux kernel, which does do access rights
testing on each individual load/store.)


> +    err |= __put_user(env->xregs[30], &sf->lr);
> +
> +    for (i = 0; i < 31; i++) {
> +        err |= __put_user(env->xregs[i], &sf->uc.tuc_mcontext.regs[i]);
> +    }
> +    err |= __put_user(env->sp, &sf->uc.tuc_mcontext.sp);
> +    err |= __put_user(env->pc, &sf->uc.tuc_mcontext.pc);
> +    err |= __put_user(env->pstate, &sf->uc.tuc_mcontext.pstate);




> +
> +    for (i = 0; i < 32 * 2; i++) {
> +       err |= __get_user(env->vfp.regs[i], &aux->fpsimd.vregs[i]);
> +    }
> +
> +#if 0
> +    err |= __get_user(env->fpsr, &aux->fpsimd.fpsr);
> +    err |= __get_user(env->fpcr, &aux->fpsimd.fpcr);
> +#endif

No #if-0 code, please.

thanks
-- PMM